Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unrevert (vert?) "Add on_unimplemented Diagnostics to Most Public Traits" #13414

Merged
merged 2 commits into from
Jun 3, 2024
Merged

Unrevert (vert?) "Add on_unimplemented Diagnostics to Most Public Traits" #13414

merged 2 commits into from
Jun 3, 2024

Conversation

alice-i-cecile
Copy link
Member

Objective

Solution

@alice-i-cecile alice-i-cecile added S-Blocked This cannot move forward until something else changes A-ECS Entities, components, systems, and events A-Cross-Cutting Impacts the entire engine labels May 17, 2024
@alice-i-cecile alice-i-cecile mentioned this pull request May 17, 2024
Merged
@alice-i-cecile alice-i-cecile added the S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it label May 17, 2024
@alice-i-cecile alice-i-cecile added this to the 0.14 milestone May 17, 2024
@alice-i-cecile alice-i-cecile removed the S-Blocked This cannot move forward until something else changes label May 23, 2024
@BD103 BD103 added the S-Blocked This cannot move forward until something else changes label May 24, 2024
@BD103
Copy link
Member

BD103 commented May 24, 2024

Unfortunately still blocked because #13366 failed the merge queue. :(

@MiniaczQ
Copy link
Contributor

MiniaczQ commented Jun 3, 2024

Unblocked

@BD103 BD103 removed the S-Blocked This cannot move forward until something else changes label Jun 3, 2024
@alice-i-cecile alice-i-cecile added this pull request to the merge queue Jun 3, 2024
Merged via the queue into bevyengine:main with commit 5ca7ba2 Jun 3, 2024
33 checks passed
@alice-i-cecile alice-i-cecile mentioned this pull request Jun 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jun 4, 2024
@alice-i-cecile @bushrat011899
@Themayu @BD103
Add on_unimplemented Diagnostics to Most Public Traits (#13347) (#1…
ec7b349 
…3662)

# Objective

- #13414 did not have the intended effect.
- #13404 is still blocked

## Solution

- Re-adds #13347.

Co-authored-by: Zachary Harrold <zac@harrold.com.au>
Co-authored-by: Jamie Ridding <Themayu@users.noreply.github.com>
Co-authored-by: BD103 <59022059+BD103@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BD103 BD103 BD103 approved these changes

Assignees
No one assigned
Labels
A-Cross-Cutting Impacts the entire engine A-ECS Entities, components, systems, and events S-Ready-For-Final-Review This PR has been approved by the community. It's ready for a maintainer to consider merging it
Projects
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alice-i-cecile @BD103 @MiniaczQ