bgpv2: container labs for various types of advertisements #32522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
harsimran-pabla
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
harsimran-pabla
added
dont-merge/needs-release-note-label
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/labs
branch
from
1ccbaa2
to
84ecd70
Compare
harsimran-pabla
requested review from
bimmlerd,
a team and
danehans
and removed request for
a team
YutaroHayakawa
requested changes
May 16, 2024
bimmlerd
requested changes
May 16, 2024
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/labs
branch
2 times, most recently
from
7b44ab4
to
6e1285f
Compare
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/labs
branch
from
6e1285f
to
c4ec47f
Compare
|
@YutaroHayakawa @bimmlerd Please have another look at this PR when you get a chance 🙏 |
Adding lab to demonstrate two BGP neighbors from same node to which pod CIDR prefixes are advertised. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
Adding lab to demonstrate advertisement of CiliumPodIPPool using BGPv2 APIs. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
Adding labs to show service advertisements for load-balancer, external IP and cluster IP using BGPv2 APIs. Also adding example of PodCIDR advertisement, each using different NLRI attributes. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
Container lab directory contains only BGP specific labs. Assigning directory code ownership to sig-bgp for time being. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/labs
branch
from
c4ec47f
to
0c9f580
Compare
Adding readme files to provide pre-requisites required to run container lab kind kubernetes cluster. As well as documentation about individual lab. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
harsimran-pabla
force-pushed
the
hpabla/bgp/v2/labs
branch
from
0c9f580
to
abe8015
Compare
YutaroHayakawa
approved these changes
May 28, 2024
bimmlerd
approved these changes
May 28, 2024
|
Not sure if a full test run is required for this change? There is no modification to the core Cilium code base, just new labs in contrib directory. @YutaroHayakawa @joestringer any concerns about adding ready-to-merge label manually, since basic pull request checks have passed? |
|
/test |
|
Making an exception since this is just going into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding container labs for local development and testing of BGPv2 APIs.
PR is split by BGP advertisement type