-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgpv1: filter terminating backends from endpoint selection #32536
bgpv1: filter terminating backends from endpoint selection #32536
Conversation
Filtering out backends which are terminating when creating local endpoint state. This will result in quicker route withdrawal if local backends go into terminating state, without waiting for graceful shutdown period of the pods. Signed-off-by: harsimran pabla <hpabla@isovalent.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
While this is definitely an improvement (and does solve the immediate problem!), would it make more sense to enumerate Edit: |
Hi @bewing, I am not sure if I understand your concern.
We are using cilium internal Endpoints representation. Do you have some concern that we should be using an alternative approach ? |
My concern was that endpoint didn't have the same data available as
However, given that testing shows that a pod failing its readiness check doesn't contribute to a node's BGP advertisement, the two approaches are probably functionally identical |
@bewing I see what you mean. I believe I think we can continue with this approach at this time, since there is clear case of excluding Edit: If we check here, I think |
Filtering out backends which are terminating when creating local endpoint state. This will result in quicker route withdrawal if local backends go into terminating state, without waiting for graceful shutdown period of the backend pod.
Fixes: #32487