Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clustermesh: expose ServicesSynced on endpointslicesync #32538

Merged
merged 1 commit into from
May 21, 2024
Merged

clustermesh: expose ServicesSynced on endpointslicesync #32538

merged 1 commit into from
May 21, 2024

Conversation

MrFreezeex
Copy link
Member

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • If your commit description contains a Fixes: <commit-id> tag, then
    please add the commit author[s] as reviewer[s] to this issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Are you a user of Cilium? Please add yourself to the Users doc
  • Thanks for contributing!

Expose ServicesSynced method from endpointslicesync for consumer to wait on initial sync.
Followup on #32287 as I noticed for the implementation of MCS-API ServiceImport controller that I needed to wait for the services to be synced.

Also add a panic if ServiceSynced returns an error.

Expose clustermesh ServicesSynced method from endpointslicesync ClusterMesh

@MrFreezeex MrFreezeex requested a review from a team as a code owner May 14, 2024 20:51
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 14, 2024
@MrFreezeex
Copy link
Member Author

/test

@MrFreezeex MrFreezeex mentioned this pull request May 15, 2024
Open
8 tasks
YutaroHayakawa
YutaroHayakawa requested changes May 16, 2024
View reviewed changes
Copy link
Member

@YutaroHayakawa YutaroHayakawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, the change is good, but I have an opinion about the panic you introduced.

pkg/clustermesh/endpointslicesync/clustermesh.go Outdated Show resolved Hide resolved
@MrFreezeex
clustermesh: expose ServicesSynced on endpointslicesync
cf5dab2 
Expose ServicesSynced method from endpointslicesync for consumer to wait
on initial sync.

Also add a log warning if ServiceSynced returns an error.

Signed-off-by: Arthur Outhenin-Chalandre <arthur@cri.epita.fr>
@YutaroHayakawa YutaroHayakawa added the release-note/misc This PR makes changes that have no direct user impact. label May 21, 2024
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label May 21, 2024
@YutaroHayakawa
Copy link
Member

/test

@MrFreezeex
Copy link
Member Author

/ci-clustermesh

@MrFreezeex
Copy link
Member Author

/ci-multi-pool

@MrFreezeex
Copy link
Member Author

/ci-clustermesh

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 21, 2024
@julianwiedmann julianwiedmann added the area/clustermesh Relates to multi-cluster routing functionality in Cilium. label May 21, 2024
@julianwiedmann julianwiedmann added this pull request to the merge queue May 21, 2024
Merged via the queue into cilium:main with commit ea9ddf1 May 21, 2024
64 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YutaroHayakawa YutaroHayakawa YutaroHayakawa approved these changes

Assignees
No one assigned
Labels
area/clustermesh Relates to multi-cluster routing functionality in Cilium. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MrFreezeex @YutaroHayakawa @julianwiedmann