Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

helm: add nodeSelector to preflight DaemonSet #32548

Merged
merged 1 commit into from
May 16, 2024
Merged

helm: add nodeSelector to preflight DaemonSet #32548

merged 1 commit into from
May 16, 2024

Conversation

squeed
Copy link
Contributor

@squeed squeed commented May 15, 2024

We had the value, but forgot to plumb it in.

Fixes: #32497

Fixes accidentally ignoring the preflight.nodeSelector Helm value.

@squeed
helm: add nodeSelector to preflight DaemonSet
cda96ac 
We had the value, but forgot to plumb it in.

Fixes: cilium#32497

Signed-off-by: Casey Callendrello <cdc@isovalent.com>
@squeed squeed added kind/bug This is a bug in the Cilium logic. release-note/bug This PR fixes an issue in a previous release of Cilium. labels May 15, 2024
@squeed squeed requested review from a team as code owners May 15, 2024 11:34
@squeed squeed requested review from joamaki and gandro May 15, 2024 11:34
@squeed squeed added needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 15, 2024
@squeed
Copy link
Contributor Author

squeed commented May 15, 2024

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label May 16, 2024
@squeed squeed added this pull request to the merge queue May 16, 2024
Merged via the queue into cilium:main with commit a1e5295 May 16, 2024
65 of 66 checks passed
@squeed squeed deleted the fix-preflight-nodeselector branch May 16, 2024 10:18
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 23, 2024
Merged
15 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. and removed needs-backport/1.15 This PR / issue needs backporting to the v1.15 branch labels May 23, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 24, 2024
Merged
12 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. and removed needs-backport/1.14 This PR / issue needs backporting to the v1.14 branch labels May 24, 2024
@YutaroHayakawa YutaroHayakawa mentioned this pull request May 24, 2024
Merged
10 tasks
@YutaroHayakawa YutaroHayakawa added backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. and removed needs-backport/1.13 This PR / issue needs backporting to the v1.13 branch labels May 24, 2024
@github-actions github-actions bot added backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. and removed backport-pending/1.15 The backport for Cilium 1.15.x for this PR is in progress. backport-pending/1.14 The backport for Cilium 1.14.x for this PR is in progress. labels May 25, 2024
@github-actions github-actions bot added backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. and removed backport-pending/1.13 The backport for Cilium 1.13.x for this PR is in progress. labels May 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@joamaki joamaki joamaki approved these changes

Assignees
No one assigned
Labels
backport-done/1.13 The backport for Cilium 1.13.x for this PR is done. backport-done/1.14 The backport for Cilium 1.14.x for this PR is done. backport-done/1.15 The backport for Cilium 1.15.x for this PR is done. kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/bug This PR fixes an issue in a previous release of Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Helm Values: preflight.nodeSelector Does Not Render Correctly
4 participants
@squeed @gandro @joamaki @YutaroHayakawa