healthv2: Various fixes #32549
Merged
healthv2: Various fixes #32549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Set the message that was passed in Degraded() - Show the degraded error in table dump and in debug logs Signed-off-by: Jussi Maki <jussi@isovalent.com>
deletePrefix used LowerBound without checking the prefix, and thus would've iterated over and deleted statuses that did not match prefix. Use Prefix() search instead. Signed-off-by: Jussi Maki <jussi@isovalent.com>
The message & level might stay the same but error may change, so check for that as well before skipping the update. Signed-off-by: Jussi Maki <jussi@isovalent.com>
QueryFromObject is pretty indirect. Better to do the queries directly with the search term. Signed-off-by: Jussi Maki <jussi@isovalent.com>
If a health reporter has not been used we should not insert an (empty) status when it stops. Signed-off-by: Jussi Maki <jussi@isovalent.com>
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joamaki
added
the
release-note/misc
maintainer-s-little-helper
bot
removed
the
dont-merge/needs-release-note-label
dylandreimerink
approved these changes
May 15, 2024
|
/test |
1 similar comment
|
/test |
maintainer-s-little-helper
bot
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a set of small issues with healthv2:
Marking this as
release-note/miscas healthv2 is not yet part of any released version.