Add partial applicative typeclass functions #2545
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…asses. We already have the ' .foo.' pattern for these typeclasses. However, you often have to use '.foo . pure bar' if 'bar' is a constant. After this change, you can use '.foo bar' instead.
lmbollen
force-pushed
the
add-partial-applicative-typeclass-functions
branch
from
cd095db
to
9158361
Compare
Comment on lines
+1448
to
+1449
| (.==) :: (Eq a, Applicative f) => f a -> a -> f Bool | ||
| (.==) a b = fmap (==b) a |
There was a problem hiding this comment.
All of these new functions where only one argument is in a container don't need to be Applicative, only Functor. You hint at this in the implementations already: only fmap is needed to define these functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have functions like
.==.that can operate onSignals. However, I find myself often writing.foo. pure barwhen comparing signals to constants.With these changes(inspired by @gergoerdi's retrocomputing lib) we can write
.foo barinstead.Still TODO: