cabal: Make workaround-ghc-mmap-crash a noop on non-x86_64 (copy #2657) #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
martijnbastiaan
force-pushed
the
mergify/copy/1.6/pr-2657
branch
from
2a80ebd
to
0b4733c
Compare
DigitalBrains1
requested changes
Mar 3, 2024
There was a problem hiding this comment.
Did you intend to include parts of commit Pass the mmap bug workaround flags via ghc-options in the ~/.cabal/config, specifically adding the workaround to clash-lib:unittests and clash-prelude:unittests? If so, could you please update the commit message and the PR cover letter and title?
|
I only tried to solve the cherry-pick / merge conflict Mergify put here: 2a80ebd. Should I have done anything else? |
|
Right, I see. I'll fix it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.