Detect and throw error on "broken" GHCs #2711
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonschoorl
reviewed
May 6, 2024
| { what = "Clash starts really slowly from GHC 9.4.8 up to and including 9.6.2" | ||
| , solution = "Downgrade to GHC 9.4.7 or upgrade to GHC 9.6.3 or newer" | ||
| , issue = "https://github.com/clash-lang/clash-compiler/issues/2710" | ||
| , brokenOn = (All, GhcMinor 9 4 8) : [(All, GhcMinor 9 6 n) | n <- [1, 2]] |
There was a problem hiding this comment.
Instead of listing all broken (minor) versions individually, I think it would be better to specify ranges of broken versions.
Something like:
, brokenOn = [(All, GhcRange { from = GhcMinor 9 4 8, to = GhcMinor 9 6 2 }]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We know some GHC versions interact poorly with Clash on some platforms. Rather than making everyone hunt down the right tickets on their own, this patch makes Clash emit a fat
warningerror. Because these issues don't completely prevent Clash from working, we allow users to bypass the error by passing a flag-fclash-ignore-broken-ghcs.Still TODO: