Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unnecessary VPI objects from discovery #3353

Open
ktbarrett opened this issue Jun 28, 2023 · 0 comments · May be fixed by #3360
Open

Remove unnecessary VPI objects from discovery #3353

ktbarrett opened this issue Jun 28, 2023 · 0 comments · May be fixed by #3360
Assignees
@ktbarrett
Labels
category:codebase:gpi relating to the GPI or one of the implementations

Comments

@ktbarrett
Copy link
Member

Remove support for the discovery of initial, always, and function blocks from the VPI, and potentially other interfaces. The discovery of these blocks is of little actual value, especially seeing as variables cannot be declared in initial or always blocks and discovery of function blocks does not allow the discovery of per-instance local variables.

cocotb/cocotb/share/lib/vpi/VpiImpl.cpp

Lines 138 to 140 in c28a922

case vpiAlways:
case vpiFunction:
case vpiInitial:

Removing these should impact exactly 0 people, but will affect the results of the discovery tests in the regressions.
@ktbarrett ktbarrett added the category:codebase:gpi relating to the GPI or one of the implementations label Jun 28, 2023
@ktbarrett ktbarrett mentioned this issue Jul 6, 2023
Open
ktbarrett added a commit that referenced this issue Jul 6, 2023
@ktbarrett
Remove unnecessary objects from VPI discovery
27198be 
Closes #3353.

Need investigation into whether the following should also be removed.
- [ ] `vpiGate`
- [ ] `vpiPort`
- [ ] `vpiPrimTerm`
- [ ] `vpiRefObj`
@ktbarrett ktbarrett linked a pull request Jul 6, 2023 that will close this issue
Open
4 tasks
@ktbarrett ktbarrett mentioned this issue Jul 15, 2023
Open
8 tasks
@ktbarrett ktbarrett self-assigned this Dec 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ktbarrett ktbarrett

Labels
category:codebase:gpi relating to the GPI or one of the implementations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove unnecessary objects from VPI discovery cocotb/cocotb
1 participant
@ktbarrett