Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary objects from VPI discovery #3360

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ktbarrett
Copy link
Member

@ktbarrett ktbarrett commented Jul 6, 2023

Closes #3353.

Need investigation into whether the following should also be removed.

  • vpiGate
  • vpiPort
  • vpiPrimTerm
  • vpiRefObj

@ktbarrett
Copy link
Member Author

Perhaps we need to add a case where we expect the type, but throw the object away because we know it isn't valuable?

@ktbarrett ktbarrett marked this pull request as ready for review July 15, 2023 18:55
@ktbarrett
Copy link
Member Author

Apparently there is a test to see if we can find a SV gate, but I'm not sure yet finding gates is even useful, so I'm testing to see if the input and output "ports" can be found.

@ktbarrett
Copy link
Member Author

We can't see any signals under a gate object, so their discovery is not important. The access_gate test will be removed.

@ktbarrett
Copy link
Member Author

This is actually a bigger PITA than expected. Our "expected don't cares" are still passed back up to the GPI layer as NULLs, which get encoded as GPI_NOT_NATIVE objects, causing an error. This occurs when iterators over hierarchies are done.

@ktbarrett
Copy link
Member Author

The discovery tests are now not finding certain objects. Investigation is needed to find out what's now missing after removing objects from iteration.

@marlonjames marlonjames added category:codebase:gpi relating to the GPI or one of the implementations type:cleanup cleanup or refactoring on code, documentation, or other areas labels Oct 12, 2023
@ktbarrett
Copy link
Member Author

Rerunning CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:codebase:gpi relating to the GPI or one of the implementations type:cleanup cleanup or refactoring on code, documentation, or other areas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unnecessary VPI objects from discovery
2 participants