-
Notifications
You must be signed in to change notification settings - Fork 486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unnecessary objects from VPI discovery #3360
base: master
Are you sure you want to change the base?
Conversation
Perhaps we need to add a case where we expect the type, but throw the object away because we know it isn't valuable? |
27198be
to
60dc3be
Compare
Apparently there is a test to see if we can find a SV gate, but I'm not sure yet finding gates is even useful, so I'm testing to see if the input and output "ports" can be found. |
We can't see any signals under a gate object, so their discovery is not important. The |
7f09378
to
c032f61
Compare
This is actually a bigger PITA than expected. Our "expected don't cares" are still passed back up to the GPI layer as NULLs, which get encoded as GPI_NOT_NATIVE objects, causing an error. This occurs when iterators over hierarchies are done. |
The discovery tests are now not finding certain objects. Investigation is needed to find out what's now missing after removing objects from iteration. |
Rerunning CI. |
24eea5c
to
3a41b2d
Compare
3a41b2d
to
9039647
Compare
Closes #3353.
Need investigation into whether the following should also be removed.
vpiGate
vpiPort
vpiPrimTerm
vpiRefObj