Cleanup handle (Part ???) #3777
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbarrett
force-pushed
the
cleanup-handle
branch
3 times, most recently
from
bca0f26
to
424847e
Compare
marlonjames
added
type:cleanup
cmarqu
reviewed
Mar 16, 2024
ktbarrett
force-pushed
the
cleanup-handle
branch
from
424847e
to
a0dc25a
Compare
|
Blocked by #3608. I plan on making a |
Adds simulator.get_indexable to test an object for indexability, while still allowing the user to get the range.
This adds the range, left, direction, and right properties which should be more intuitive than the previous `_range` and `_range_iter` methods.
This changes the return type of ArrayObjects to be Arrays. This allows the simulator objects indexing to be used rather than just 0 to length-1 as was done for list. Lists, and now any sequence, is still accepted when setting the value in addition to Array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more changes.
strtoLogicObjectsleft,right,direction, andrangetoArrayObject,LogicObjectandStringObject.IndexableValueObjectBase, onlyArrayObjectnow support indexing and iteration.