Verilator VPI dirty optimization #3861
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imphil
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3861 +/- ##
==========================================
+ Coverage 72.68% 73.16% +0.47%
==========================================
Files 49 49
Lines 8058 7952 -106
Branches 2218 2209 -9
==========================================
- Hits 5857 5818 -39
+ Misses 1694 1612 -82
- Partials 507 522 +15 ☔ View full report in Codecov by Sentry. |
marlonjames
reviewed
Apr 24, 2024
|
|
||
| // Call Value Change callbacks triggered by eval() | ||
| // These can modify signal values | ||
| again = settle_value_callbacks(); | ||
| settle_value_callbacks(); |
There was a problem hiding this comment.
If we really don't care if any callbacks were called, you can change the function to not return anything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending verilator/verilator#5065 and probably a Verilator release due to the API change.
This doesn't appear to do much for
test_matrix_multiplier_verilatorbut it's made noticeable performance improvements for us locally (think a monitor coro which doesn't touch the DUT).