More 1.9 changes #3878
Open
More 1.9 changes #3878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktbarrett
force-pushed
the
more-1.9-changes
branch
2 times, most recently
from
c7bf538
to
0a2431b
Compare
ktbarrett
force-pushed
the
more-1.9-changes
branch
from
0a2431b
to
54b274c
Compare
ktbarrett
commented
May 3, 2024
| @@ -721,7 +721,15 @@ def __init__(self, coroutine): | |||
|
|
|||
| @property | |||
| def _outcome(self): | |||
| return self._coroutine._outcome | |||
| outcome = self._coroutine._outcome | |||
| if type(self._coroutine) is Task and isinstance(outcome, outcomes.Error): | |||
There was a problem hiding this comment.
Have to explicitly check for Task so that all @cocotb.coroutine "tasks" don't issue this warning.
ktbarrett
force-pushed
the
more-1.9-changes
branch
2 times, most recently
from
73f24c4
to
1235d6b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/1.9 #3878 +/- ##
==============================================
- Coverage 64.79% 64.49% -0.30%
==============================================
Files 49 49
Lines 9131 9142 +11
Branches 2461 2469 +8
==============================================
- Hits 5916 5896 -20
- Misses 2627 2652 +25
- Partials 588 594 +6 ☔ View full report in Codecov by Sentry. |
ktbarrett
force-pushed
the
more-1.9-changes
branch
4 times, most recently
from
b14cc6e
to
64f207f
Compare
Had to fix a number of tests in test_timing_triggers because of propagation of warnings as exceptions. Chucked a couple tests that were testing the thing we were removing and the awful test_readwrite_in_readonlhy.
Also deprecate with an explicit warning the .value attribute that was deprecated in the documentation only.
Calls to find_libpython.find_libpython() may return an empty string or None if libpython was not properly installed. This was causing a TypeError exception to be thrown with a non-obvious error message. The value returned by find_libpython.find_libpython() is now checked and if not found a more helpful error message is provided.
ktbarrett
force-pushed
the
more-1.9-changes
branch
from
64f207f
to
16a222d
Compare
|
Waiting on outcome of whether the python installation requirements are correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
FutureWarningwhen Tasks throw an exception. The current behavior is the opposite of what's going to happen in 2.0. Also close #3845. Also backports #3879 and #3868.