-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/1.7] Fix issue with empty host tree in hosts.toml #10028
base: release/1.7
Are you sure you want to change the base?
Conversation
Hi @brandond. Thanks for your PR. I'm waiting for a containerd member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Seems the issue here would be better fixed by just changing |
Sure, that'd work too. It didn't seem like there was much point in calling
I don't know, I didn't poke at the toml parser return; I suspect it just returns an empty tree so that |
Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Note this fix is not needed in main as we have bumped the toml library major version and the new implementation does not have this issue. |
Is this fix needed in 1.6, or not affected? |
Can you squash commits and describe the issue in the commit? |
Fixes: #10027