[v4.4.1-crio] Bump c/common to v0.52.0 #22355
Conversation
openshift-ci
bot
added
release-note-none
approved
|
@kwilczynski PTAL This is dragging a ton of stuff in, I hope it's not too much. |
TomSweeneyRedHat
added
the
do-not-merge/hold
go.mod
Outdated
| github.com/containers/conmon v2.0.20+incompatible | ||
| github.com/containers/image/v5 v5.24.1 | ||
| github.com/containers/image/v5 v5.25.0 |
There was a problem hiding this comment.
This aligns with CRI-O release 1.25. Newer releases are already on version 5.27.0 or newer.
go.mod
Outdated
| github.com/containernetworking/cni v1.1.2 | ||
| github.com/containernetworking/plugins v1.2.0 | ||
| github.com/containers/buildah v1.29.3 | ||
| github.com/containers/common v0.51.3 | ||
| github.com/containers/common v0.52.0 |
There was a problem hiding this comment.
This aligns with CRI-O release 1.25. Newer releases are already on version 0.53.0 or newer.
@TomSweeneyRedHat, the two most important dependencies here for us are the We are good to go, I believe. |
|
/approve |
|
@kwilczynski: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@TomSweeneyRedHat, even though we look good from our key dependencies point of view, we have some anciliary dependency issues per: vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:122:12: undefined: system.LCOWSupported
vendor/github.com/openshift/imagebuilder/dockerfile/parser/parser.go:157:12: undefined: system.LCOWSupportedLet me have a look as to how we resolved this in CRI-O. I believe a dependency update would fix this. |
This missing method issue has been fixed in the following release of the We should upgrade the dependency to version |
go.mod
Outdated
| github.com/opencontainers/runc v1.1.12 | ||
| github.com/opencontainers/runtime-spec v1.1.0-rc.1 | ||
| github.com/opencontainers/runtime-tools v0.9.1-0.20221014010322-58c91d646d86 | ||
| github.com/opencontainers/runtime-tools v0.9.1-0.20221107090550-2e043c6bd626 | ||
| github.com/opencontainers/selinux v1.11.0 | ||
| github.com/openshift/imagebuilder v1.2.4-0.20220711175835-4151e43600df |
There was a problem hiding this comment.
@TomSweeneyRedHat, if possible, this needs a version bump to:
| github.com/openshift/imagebuilder v1.2.4-0.20220711175835-4151e43600df | |
| github.com/openshift/imagebuilder v1.2.4 |
This looks confusing; however, it's how this project tagged their release.
|
@TomSweeneyRedHat, do you think you could see about these comments:
To fix the build issue and potentially also move forward with this branch? I would be much obliged. |
openshift-merge-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
TomSweeneyRedHat
force-pushed
the
dev/tsweeney/common_0.52.0_bump-v4.4.1-crio
branch
from
74bdc90
to
6071a2b
Compare
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: kwilczynski, TomSweeneyRedHat The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
removed
the
approved
As the title says. This replaces containers#22355. I'm not sure how I managed, but the original PR: containers#22355, I accidentally pushed into the v4.4.1-crio branch as a merge commit. I've reverted that, and redid the vendor for c/common 0.52.0 This dragged in c/image v5.25.0, and I also needed to bump image builder as the version of Docker that also got dragged in dropped the LCOWSupported functionality and c/storage by that time had taken it over. So long story short, a lot more changes than I'm entirely comfortable with. @kwilczynski PTAL. Sorry about the very slow response on this, we had to get some CVE fixes first, and in so doing, discovered the CI in this branch was pretty badly broken and had to fix that . Addresses: https://issues.redhat.com/browse/OCPBUGS-32144 Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
|
Replaced by: #22944 |
As the title says, bumping the c/common package to v0.52.0
in the v4.4.1-crio branch via a request from the CRI-O team.
Addresses: https://issues.redhat.com/browse/OCPBUGS-32144
[NO NEW TESTS NEEDED]
Does this PR introduce a user-facing change?