Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: cleanup unused files/doc #22409

Merged
merged 2 commits into from
May 15, 2024
Merged

test: cleanup unused files/doc #22409

merged 2 commits into from
May 15, 2024

Conversation

Luap99
Copy link
Member

@Luap99 Luap99 commented Apr 17, 2024

see commits

None

@Luap99
Copy link
Member Author

Luap99 commented Apr 17, 2024

@edsantiago PTAL

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 17, 2024
@packit-as-a-service Packit-as-a-Service
Copy link

We were not able to find or create Copr project packit/containers-podman-22409 specified in the config with the following error:

Cannot create a new Copr project (owner=packit project=containers-podman-22409 chroots=['centos-stream+epel-next-9-x86_64', 'centos-stream+epel-next-8-x86_64', 'centos-stream+epel-next-8-aarch64', 'centos-stream+epel-next-9-aarch64']): Response is not in JSON format, there is probably a bug in the API code.

Please check your configuration for:

  1. typos in owner and project name (groups need to be prefixed with @)
  2. whether the project name doesn't contain not allowed characters (only letters, digits, underscores, dashes and dots must be used)
  3. whether the project itself exists (Packit creates projects only in its own namespace)
  4. whether Packit is allowed to build in your Copr project
  5. whether your Copr project/group is not private

@Luap99
Copy link
Member Author

Luap99 commented May 14, 2024

@edsantiago PTAL reping

edsantiago
edsantiago requested changes May 14, 2024
View reviewed changes
Copy link
Collaborator

@edsantiago edsantiago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the reping. I lost this thread somehow, and apologize for it.

The cleanup looks great to me, those tests have never been used in production AFAIK. One request inline.

test/system/README.md Outdated Show resolved Hide resolved
@Luap99
test/system: fix documentation
cb905f5 
First, point users to hack/bats for running them locally. Second, remove
TODO.md as it doesn't contain any helpful information. Basically all the
missing tests there have been added so this does not serve any purpose
and is missleading.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@Luap99
test: remove test_podman* scripts
061bcc0 
They are not run in CI and to my knowledge are not used by anyone, we
have much more/better tests in test/e2e and test/system that should
cover everything done in these scripts so just delete them to not
confuse contributors.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
@packit-as-a-service Packit-as-a-Service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 65e2ecb. @martinpitt, @jelly, @mvollmer please check.

@packit-as-a-service Packit-as-a-Service
Copy link

Cockpit tests failed for commit 061bcc0. @martinpitt, @jelly, @mvollmer please check.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: edsantiago, Luap99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@edsantiago
Copy link
Collaborator

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 15, 2024
@openshift-merge-bot openshift-merge-bot bot merged commit c4631dc into containers:main May 15, 2024
88 of 91 checks passed
@Luap99 Luap99 deleted the test-doc branch May 15, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edsantiago edsantiago edsantiago approved these changes

Assignees

@edsantiago edsantiago

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Luap99 @edsantiago