-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI:DOCS] Update podman network docs #22594
[CI:DOCS] Update podman network docs #22594
Conversation
9b98b6c
to
3560075
Compare
3560075
to
cc9a51c
Compare
cc9a51c
to
8d1b7e1
Compare
@Luap99, I made the changes as suggested. I noticed a few places in the tutorials where slirp4netns is mentioned as the default rootless network. https://github.com/containers/podman/blob/main/docs/tutorials/rootless_tutorial.md Should these be changed as well? |
yes |
8d1b7e1
to
86cb0c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chnages LGTM, we can worry about the tutorials later, let's get the fix into the man pages for now
@radar07 Can you fix your commit message and remove the
fix
fix
fix
this should also make the DCO check pass
Update the podman network docs to specify that the default rootless networking tool has been swapped from slirp4netns to pasta. Signed-off-by: Pranav RK <pranavrk7@gmail.com>
86cb0c5
to
9a8c343
Compare
Ephemeral COPR build failed. @containers/packit-build please check. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mheon PTAL
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lahwaacz, Luap99, radar07 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
d0ed271
into
containers:main
/cherry-pick v5.1 |
@Luap99: new pull request created: #22772 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Update the podman network docs to specify that the default rootless networking tool has been swapped from slirp4netns to pasta.
Fixes: 22543
Does this PR introduce a user-facing change?