Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate IsRemote call #22643

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

qianxi0410
Copy link
Contributor

Does this PR introduce a user-facing change?

None

Remove unnecessary IsRemote calls and replace them with the else syntax.

Signed-off-by: qianxi0410 <894871277@qq.com>
@mheon
Copy link
Member

mheon commented May 9, 2024

Just a refactor, adding No New Tests.

@mheon mheon added the No New Tests Allow PR to proceed without adding regression tests label May 9, 2024
@mheon
Copy link
Member

mheon commented May 9, 2024

/approve
Code LGTM

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 9, 2024
Copy link
Member

@vrothberg vrothberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

openshift-ci bot commented May 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mheon, qianxi0410, vrothberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vrothberg
Copy link
Member

/lgtm
Restarted the flaked jobs

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. No New Tests Allow PR to proceed without adding regression tests release-note-none
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants