Integration of podman with buildroot

[manunixgit]

User : Manthan Gajera

• This Pull request is regarding to integrate the podman with buildroot.

[openshift-ci]

Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: manunixgit
Once this PR has been reviewed and has the lgtm label, please assign flouthoc for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[packit-as-a-service]

Ephemeral COPR build failed. @containers/packit-build please check.

[rhatdan]

You must sign your commmits. Not really sure what buildroot is?

@lsm5 @cevich PTAL

[packit-as-a-service]

Cockpit tests failed for commit d12ebac. @martinpitt, @jelly, @mvollmer please check.

[edsantiago]

Thank you for your PR! The big question here is, what is buildroot, and why does Podman need to support it upstream and in top-level files? Secondary question is, who will support this when it breaks or needs new functionality?

A couple of comments inline, but those are just general - no need to address them until the questions above are answered.

[edsantiago]

This sort of thing is not done. A version string in any project is defined exactly once, in only one place, and never duplicated. Anything that references that version string shall obtain it from the One True Source. In our repo, the convention is something along these lines:

grep '^const RawVersion' version/rawversion/version.go | cut -d\" -f2

[cevich]

Alternative: Compile and run test/version//version, it will output the version number w/o any need to maintain grep's interpretation of golang. Though it's unlikely to change, so grep is probably fine for now.

[edsantiago]

All lines must end in \n

[lsm5]

Thank you for your PR! The big question here is, what is buildroot, and why does Podman need to support it upstream and in top-level files? Secondary question is, who will support this when it breaks or needs new functionality?

Agree with @edsantiago here. @manunixgit Buildroot is probably a very generic term and it's hard to see where and how it will be used from the commit message and diff. And we'd also need to know about maintainer commitment and availability before accepting this.