Add url,checksums and metadata to JSON report.
#2791
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the `url` and `checksums` field to the JSON report for resolve. The `checksums` field contains the all the downloaded checksums for a given artifact. Co-authored-by: Yilin Wei <yilin@kebab-ca.se>
yilinwei
force-pushed
the
add-checksum-to-report
branch
from
59c89c9
to
d31cdb2
Compare
yilinwei
changed the title
url and checksums to JSON report.url,checksums and metadata to JSON report.
yilinwei
force-pushed
the
add-checksum-to-report
branch
3 times, most recently
from
33e576c
to
f8f4df7
Compare
Add the `metadata` field to the JSON report for the fetch command with the `file`, `url` and `checksum` fields.
yilinwei
force-pushed
the
add-checksum-to-report
branch
from
f8f4df7
to
2ef15b2
Compare
|
By way of an update, this works quite well apart from the fact that the set of pom's needs to be extended to allow coursier to resolve the dependency properly. What I mean is:
then coursier needs the pom for both minor versions but not the jar for the evicted version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
url,metadataandchecksumsto the JSON report produced viafetch.Note that the checksums are the downloaded ones, not calculated from the artifacts. This is to allow a follow-up PR for #1223.
Fixes part of #1487.
There are a few outstanding issues:
parseChecksumRawSince the metadata files can reference parents (seecom.twitter::hpack), it is currently not sufficient to recreate the coursier cache just from the JSON file, since theArtifactreturned by the resolution does not contain the parent. Any ideas/pointers to solve this would be appreciated.Ideally I'd like to add the metadata files and the associated hashes so I can recreate the coursier cache within a sandbox, which would allow downstream build tools such assbtormillto build in a sandboxed environment, but that can be done in a follow up PR.