Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add numeric overloads for math functions #15644

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Add numeric overloads for math functions #15644

wants to merge 1 commit into from

Conversation

jeeminso
Copy link
Contributor

@jeeminso jeeminso commented Mar 3, 2024

Summary of the changes / Why this improves CrateDB

Fixes #15632.

Checklist

  • Added an entry in the latest docs/appendices/release-notes/<x.y.0>.rst for user facing changes
  • Updated documentation & sql_features table for user facing changes
  • Touched code is covered by tests
  • CLA is signed
  • This does not contain breaking changes, or if it does:
    • It is released within a major release
    • It is recorded in the latest docs/appendices/release-notes/<x.y.0>.rst
    • It was marked as deprecated in an earlier release if possible
    • You've thought about the consequences and other components are adapted
      (E.g. AdminUI)

@jeeminso jeeminso force-pushed the jeeminso/numeric-primitives branch from 05314b0 to 059a494 Compare March 3, 2024 23:22
@mfussenegger
Copy link
Member

mfussenegger commented Mar 4, 2024 •
edited

Please try to to phrase commit messages a bit more with user outcome in mind instead of focusing on how the code is modified.

E.g. "Add numeric overload for math functions" - or if it's not too many, list the functions.

@jeeminso
Copy link
Contributor Author

jeeminso commented Mar 7, 2024

Closing, see #15632 (comment).

@jeeminso jeeminso closed this Mar 7, 2024
@jeeminso jeeminso reopened this Mar 14, 2024
@jeeminso jeeminso force-pushed the jeeminso/numeric-primitives branch 3 times, most recently from c4957c2 to 1cf5fc0 Compare March 20, 2024 01:04
@jeeminso jeeminso changed the title Add NUMERIC type to NUMERIC_PRIMITIVE_TYPES collection Add numeric overloads for math functions Mar 20, 2024
@jeeminso jeeminso force-pushed the jeeminso/numeric-primitives branch 2 times, most recently from 43753ea to 210f74f Compare March 21, 2024 02:17
@jeeminso jeeminso force-pushed the jeeminso/numeric-primitives branch from 210f74f to fe151b4 Compare March 21, 2024 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add numeric overload for math functions
2 participants
@jeeminso @mfussenegger