Include Schemas in NodeContext #15988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jeeminso
force-pushed
the
jeeminso/schemas-nodectx
branch
10 times, most recently
from
2bf66e8
to
7d2ce80
Compare
| this.roles = roles; | ||
| this.createSchemas = createSchemas; | ||
| schemas(); |
There was a problem hiding this comment.
If this works eagerly couldn't we make it final and remove the lazy initialization logic?
jeeminso
force-pushed
the
jeeminso/schemas-nodectx
branch
from
62e644d
to
2831ce3
Compare
mfussenegger
approved these changes
May 22, 2024
jeeminso
force-pushed
the
jeeminso/schemas-nodectx
branch
5 times, most recently
from
af0c7b9
to
c292bf0
Compare
Schemas and all of its fields are no longer created by ES injector. The classes with the singleton/inject annotations removed are now manually created but some may still be injected to other instances by the injector. Co-authored-by: Mathias Fussenegger <f.mathias@zignar.net>
jeeminso
force-pushed
the
jeeminso/schemas-nodectx
branch
from
c292bf0
to
9a3be7c
Compare
jeeminso
added
the
ready-to-merge
5 tasks
mfussenegger
added a commit
that referenced
this pull request
May 29, 2024
Follow up to #15988, which removed the setter but didn't update the comment on the field.
mfussenegger
added a commit
that referenced
this pull request
May 29, 2024
Follow up to #15988, which removed the setter but didn't update the comment on the field. Also removes the unused client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this improves CrateDB
Introduce Schemas field in NodeContext which requires manual creation of the Schemas instance(moving away from the ES injector) and also all of its fields.
All the classes with the singleton/inject annotations removed are now manually created but some may still be injected to other instances.
Checklist
docs/appendices/release-notes/<x.y.0>.rstfor user facing changessql_featurestable for user facing changesdocs/appendices/release-notes/<x.y.0>.rst(E.g. AdminUI)