Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove daprClient in workflow e2e test #7313

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

MregXN
Copy link
Member

@MregXN MregXN commented Dec 18, 2023

Description

please refer to issue #1205 in dapr/dotnet-sdk.

Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
@MregXN MregXN requested review from a team as code owners December 18, 2023 03:00
@MregXN MregXN marked this pull request as draft December 18, 2023 03:00
@cgillum
Copy link
Contributor

cgillum commented Dec 18, 2023

Also tagging @RyanLettieri on this PR since he's the original author of the workflow E2E test.

Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Signed-off-by: MregXN <mregxn@gmail.com>
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.58%. Comparing base (e90b54d) to head (9602255).
Report is 224 commits behind head on master.

❗ Current head 9602255 differs from pull request most recent head 1d90c06. Consider uploading reports for the commit 1d90c06 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7313      +/-   ##
==========================================
- Coverage   64.62%   64.58%   -0.05%     
==========================================
  Files         226      226              
  Lines       21191    21191              
==========================================
- Hits        13695    13686       -9     
- Misses       6320     6325       +5     
- Partials     1176     1180       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MregXN
Copy link
Member Author

MregXN commented Dec 19, 2023

this pr will be ready for review after this issue in dotnet-sdk is fixed.

@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added the stale Issues and PRs without response label Feb 17, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically closed because it has not had activity in the last 67 days. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot closed this Feb 24, 2024
@yaron2 yaron2 reopened this Feb 24, 2024
@dapr-bot dapr-bot removed the stale Issues and PRs without response label Feb 24, 2024
@dapr-bot
Copy link
Collaborator

This pull request has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions!

@dapr-bot dapr-bot added stale Issues and PRs without response and removed stale Issues and PRs without response labels Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants