Healthz overhaul #7518
Open
Healthz overhaul #7518
+1,204
−567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #7518 +/- ##
==========================================
+ Coverage 61.39% 61.81% +0.42%
==========================================
Files 265 247 -18
Lines 22609 22477 -132
==========================================
+ Hits 13880 13894 +14
+ Misses 7579 7417 -162
- Partials 1150 1166 +16 ☔ View full report in Codecov by Sentry. |
JoshVanL
added
the
autoupdate
JoshVanL
force-pushed
the
healthz-overhaul
branch
from
6ecfa37
to
6b5457b
Compare
JoshVanL
force-pushed
the
healthz-overhaul
branch
2 times, most recently
from
d356488
to
8f2ef5f
Compare
|
@JoshVanL please resolve conflicts |
JoshVanL
force-pushed
the
healthz-overhaul
branch
from
263d8b8
to
ca9dc6d
Compare
|
@yaron2 fixed |
yaron2
reviewed
Mar 26, 2024
JoshVanL
force-pushed
the
healthz-overhaul
branch
2 times, most recently
from
ca58813
to
92b8f10
Compare
|
/ok-to-test |
1 similar comment
|
/ok-to-test |
Dapr E2E testCommit ref: bf7d98b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
❌ Tests failed on windows/amd64Please check the logs for details on the error. ❌ Tests failed on linux/amd64Please check the logs for details on the error. |
Dapr E2E testCommit ref: bf7d98b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
✅ Tests succeeded on windows/amd64
✅ Tests succeeded on linux/amd64
|
|
/ok-to-test |
2 similar comments
|
/ok-to-test |
|
/ok-to-test |
Dapr E2E testCommit ref: bf7d98b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
❌ Tests failed on windows/amd64Please check the logs for details on the error. ✅ Tests succeeded on linux/amd64
|
Dapr E2E testCommit ref: bf7d98b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
✅ Tests succeeded on windows/amd64
✅ Tests succeeded on linux/amd64
|
Dapr E2E testCommit ref: bf7d98b ✅ Build succeeded for linux/amd64
✅ Infrastructure deployed
✅ Build succeeded for windows/amd64
❌ Tests failed on windows/amd64Please check the logs for details on the error. ✅ Tests succeeded on linux/amd64
|
JoshVanL
force-pushed
the
healthz-overhaul
branch
from
87dfaef
to
d2e5aa7
Compare
JoshVanL
force-pushed
the
healthz-overhaul
branch
2 times, most recently
from
d491f2a
to
85ea707
Compare
Currently, the healthz endpoint on Dapr services do not represent the actual health of the service as they are mostly only spinning up a HTTP server and immediately returning a 200 OK. This results in services receiving traffic before they are ready to actually serve requests. This issue manifests in integration tests where, for example, no metrics are available on the metrics endpoint even though the service reports as healthy and therefore fails the test. This PR overhauls the healthz package to allow registering health targets during the service `New` process chain. Each module marks their target as healthy and the healthz server reports the overall health of the service. Although not perfect, service healthz endpoints should now be more representative of the actual health of the program. Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
healthz-overhaul
branch
from
bb8218a
to
14bad27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the healthz endpoint on Dapr services do not represent the actual health of the service as they are mostly only spinning up a HTTP server and immediately returning a 200 OK. This results in services receiving traffic before they are ready to actually serve requests. This issue manifests in integration tests where, for example, no metrics are available on the metrics endpoint even though the service reports as healthy and therefore fails the test.
This PR overhauls the healthz package to allow registering health targets during the service
Newprocess chain. Each module marks their target as healthy and the healthz server reports the overall health of the service. Although not perfect, service healthz endpoints should now be more representative of the actual health of the program.