Test Integration: add basic and app restart actor timer tests #7534
Conversation
|
/test-version-skew |
Dapr Version Skew integration test (dapr-sidecar-master - 1.12.5)Commit ref: 7775d6f ❌ Version Skew tests failedPlease check the logs for details on the error. |
Dapr Version Skew e2e test (dapr-sidecar-master - 1.12.5)Commit ref: 7775d6f ✅ Version Skew tests passed |
Dapr Version Skew integration test (control-plane-master - 1.12.5)Commit ref: 7775d6f ✅ Version Skew tests passed |
Dapr Version Skew e2e test (control-plane-master - 1.12.5)Commit ref: 7775d6f ✅ Version Skew tests passed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release-1.13 #7534 +/- ##
================================================
- Coverage 62.14% 62.04% -0.10%
================================================
Files 245 245
Lines 22410 22440 +30
================================================
- Hits 13926 13924 -2
- Misses 7325 7355 +30
- Partials 1159 1161 +2 ☔ View full report in Codecov by Sentry. |
JoshVanL
force-pushed
the
test-integration-actors-timers
branch
from
7775d6f
to
c807d3a
Compare
Adds integration tests for basic timer functionality, as well as ensuring a timer will not continue to be triggered after the application has been marked as unhealthy. Adds the following environment variables in order to speed up the actor app being marked as unhealthy. This speeds the test to 4s from 20s without the changes. These environment variables will be removed as and when the actor health check is merged into the app health check. ``` DAPR_EXPERIMENTAL_ACTOR_HEALTH_FAILURE_THRESHOLD DAPR_EXPERIMENTAL_ACTOR_HEALTH_UNHEALTHY_INTERVAL DAPR_EXPERIMENTAL_ACTOR_HEALTH_HEALTHY_INTERVAL DAPR_EXPERIMENTAL_ACTOR_HEALTH_REQUEST_TIMEOUT ``` Signed-off-by: joshvanl <me@joshvanl.dev>
JoshVanL
force-pushed
the
test-integration-actors-timers
branch
from
c807d3a
to
065ba5a
Compare
| @@ -63,6 +64,11 @@ const ( | |||
|
|
|||
| errStateStoreNotFound = "actors: state store does not exist or incorrectly configured" | |||
| errStateStoreNotConfigured = `actors: state store does not exist or incorrectly configured. Have you set the property '{"name": "actorStateStore", "value": "true"}' in your state store component file?` | |||
|
|
|||
| envKeyHealthFailureThreshold = "DAPR_EXPERIMENTAL_ACTOR_HEALTH_FAILURE_THRESHOLD" | |||
There was a problem hiding this comment.
Have we agreed to the "DAPR_EXPERIMENTAL" as the official way to introduce env variables?
I don't have a problem with it. Just checking we had done the vetting on this.
There was a problem hiding this comment.
No we haven't, and I'd definitely like feedback for it. It seems like the right thing to do, but there may already exist a mechanism in Dapr I'm not aware of.
Ideally, we would merge the actor and app health checks into the same routine which would drop the need for this at all.
The main reason for this to exist is for integration tests not to take an unreasonable amount of time, though real users could see benefit from it in theory.
JoshVanL
added
the
autoupdate
Adds integration tests for basic timer functionality, as well as
ensuring a timer will not continue to be triggered after the application
has been marked as unhealthy.
Adds the following environment variables in order to speed up the actor
app being marked as unhealthy. This speeds the test to 4s from 20s
without the changes.
These environment variables will be removed as and when the actor health
check is merged into the app health check.