blockchain: Ensure no stake opcodes in tx sanity. #1453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
blockchain_no_stake_opcodes_tx_sanity
branch
from
28f1703
to
4e97fcb
Compare
dnldd
approved these changes
Sep 14, 2018
alexlyp
approved these changes
Sep 14, 2018
davecgh
commented
Sep 14, 2018
This moves the check for validating that output scripts in non-stake transactions do not contain any of the opcodes only allowed in the stake tree to the CheckTransactionSanity function where it more naturally belongs since it does not require access to transaction inputs as its location in CheckTransactionInputs would otherwise indicate. It should be noted that the check just before the one being moved in this change is removed because it checked that specific patterns involving stake opcodes where not being used in non-stake transactions which is a strict subset of the more general check which ensures there are no stake opcodes at all in the output scripts. Also, to improve efficiency, the check is added to the existing loop which already iterates the outputs and the entire block is moved after some other faster checks. Finally, since the transaction sanity code previously did not determine if the transaction is a stake transaction which is required for the check in question, this adds code to relatively efficiently determine that.
davecgh
force-pushed
the
blockchain_no_stake_opcodes_tx_sanity
branch
from
4e97fcb
to
37315c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires PR #1452.
This moves the check for validating that output scripts in non-stake transactions do not contain any of the opcodes only allowed in the stake tree to the
CheckTransactionSanityfunction where it more naturally belongs since it does not require access to transaction inputs as its location inCheckTransactionInputswould otherwise indicate.It should be noted that the check just before the one being moved in this change is removed because it checked that specific patterns involving stake opcodes where not being used in non-stake transactions which is a strict subset of the more general check which ensures there are no stake opcodes at all in the output scripts.
Also, to improve efficiency, the check is added to the existing loop which already iterates the outputs and the entire block is moved after some other faster checks.
Finally, since the transaction sanity code previously did not determine if the transaction is a stake transaction which is required for the check in question, this adds code to relatively efficiently determine that.
This is work towards #1145.