blockmanager: Decouple from global config var. #2497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davecgh
force-pushed
the
bmgr_no_global_cfg_dep
branch
from
877d942
to
8220de9
Compare
dnldd
reviewed
Dec 10, 2020
dnldd
reviewed
Dec 10, 2020
davecgh
force-pushed
the
bmgr_no_global_cfg_dep
branch
from
8220de9
to
9e2cf70
Compare
dnldd
approved these changes
Dec 10, 2020
matheusd
approved these changes
Dec 14, 2020
This decouples the code releated to loading and dumping the block database from the block manager and moves it into a separate file. This is part of an overall effort to remove all dependencies on the global config variable from the block manager.
This adds configuration parameters used by the block manager to its own config struct versus directly using the global config variable.
davecgh
force-pushed
the
bmgr_no_global_cfg_dep
branch
from
9e2cf70
to
03931c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This decouples the block manager from the global config variable as part of an overall effort to eventually split it into its own package.
It consists of three commits which:
This is work towards #1145.