spv: Move getheaders stage to global syncer instead of per-peer #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusd
force-pushed
the
global-getheaders
branch
from
4938beb
to
cc42b80
Compare
jrick
reviewed
Nov 17, 2023
jrick
reviewed
Nov 17, 2023
This moves the fetch headers and cfilters from the peer startup to the syncer startup. This avoids wasting duplicate effort for every peer. In the future, this will allow using multiple peers to fetch headers and cfilters from, as well as allowing asynchronous fetching.
The locators are now only needed during the initial getHeaders sync stage, therefore they are not needed in the global syncer struct. Since they are accessed only from a single goroutine now, the mutex is also unneeded.
matheusd
force-pushed
the
global-getheaders
branch
from
cc42b80
to
0203f76
Compare
jrick
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the fetch headers and cfilters stage from the per-peer startup function to the main syncer startup function.
This avoids wasting duplicate effort for every peer. In the future, this will allow using multiple peers to fetch headers and cfilters from, as well as allowing asynchronous fetching.
This change significantly reduces the amount of resources (cpu, ram, goroutines) used during the initial sync at the cost of increasing the sync time. The sync time will be reduced in the future as well, after parallelizing the headers/cfilters/chainswitch stages and after batched cfilter fetching is implemented and deployed.
Part of #2289