PermissionButton improvements #94
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delba
reviewed
Mar 5, 2017
| @@ -450,7 +450,15 @@ open class PermissionButton: UIButton { | |||
| Tells the view that its superview changed. | |||
| */ | |||
| open override func didMoveToSuperview() { | |||
| render(.normal) | |||
There was a problem hiding this comment.
Could you use render() here please? I prefer to keep update() solely as a public interface.
This was referenced Mar 5, 2017
|
Anything new here? I did the requested change two weeks ago, still not merged though. |
|
@delba What about merging this? |
|
@delba Ping. |
|
@delba do you mind taking a second pass at this when you get a free second? |
|
@jeffaburt @CraigSiemens See my comment here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the PermissionButton in an app I recognised two issues. I opened an issue for each:
This PR solves both #92 and #93 and probably also #116.
NOTE: Since @delba is not answering, I've integrated #90 to this PR. If you want to use a iOS 10, Xcode 9 and Swift 4 compatible version of this framework, feel free to integrate my fork instead:
https://github.com/Dschee/Permission