-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cli/coverage): invalid line id in html reporter #23908
Conversation
Thanks, any chance you could update the existing HTML reporter test to exercise this change? |
@bartlomieju I can, however I'm not sure where it is located. Is it supposed to be somewhere in the same rust file or is it like in another test folder ? |
@lowlighter there is a |
The change looks good to me. @lowlighter
and asserts specific part of output html files. Nevermind. You've already done it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. Thanks!
The
name
for the anchors are prefixed with aL
, but the links are currently missing it so they don't work currently: