Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update uploader documentation #200

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

pakhomov-dfinity
Copy link

No description provided.

@pakhomov-dfinity pakhomov-dfinity self-assigned this Apr 28, 2023
@pakhomov-dfinity pakhomov-dfinity requested a review from a team as a code owner April 28, 2023 11:12
bootstrap/README.md Outdated Show resolved Hide resolved
Comment on lines +30 to +35
## 3. Checkout the working revision
See [Proposal](https://dashboard.internetcomputer.org/proposal/94253)

```
git checkout fdfced51d002d7f16908642f29216a869ecd3627
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The steps here are not specific to computing the state we did in this proposal, so I'd remove this. To validate that specific proposal, you should follow the instructions in the launch branch.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The launch proposal has relevant updates, e.g. uploader canister accepts hardcoded list of hashes. Otherwise one needs to pass more hashes than possible to shove into dfx call as startup flags, which I failed to do.

Comment on lines +98 to +100
`dfx` version `0.12.1` is known to work

Add desired network to the `dfx.json` and set `NETWORK` to match it.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dfx.json is already at version 0.13.1. Why go back to 0.12.1?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.13 doesn't create canisters on testnets

Comment on lines +121 to +123
## 10. Hardcode the canister id into the replica binary

Set the bitcoin canister id in `rs/config/src/execution_environment.rs` to match the uploader canister id. Note that "mainnet" and "testnet" stand for the BTC netwrok version, not IC. Build image and upgrade the subnet.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is no longer necessary. You can now deploy a testnet with the flag --allow-specified-ids and with that you can create the canister with the same ID as the bitcoin canister in production.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack, I need to test how it works

@@ -77,3 +84,59 @@ cargo run --release --example compute_hashes -- --file ./canister_state.bin > ch
```

The hash of each chunk is saved in `chunk_hashes.txt`.

## 7. Hardcode the caches into the uploader canister
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The instructions below here are quite specific for testnets. Can we add a note perhaps that clarifies that the remaining instructions are testnet-specific?

@ielashi
Copy link
Collaborator

ielashi commented May 9, 2023

Thanks the for the details instructions @pakhomov-dfinity. I left a few minor comments.

Co-authored-by: Islam El-Ashi <islam.elashi@dfinity.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants