Skip to content

Commit

Permalink
Merge branch 'NNS1-2448' into 'master'
Browse files Browse the repository at this point in the history
[NNS1-2448] Support settling the Neurons' fund for 1-proposal

System testing of the 1-proposal feature uncovered that the settling of the neurons' fund was not completely implemented. In this MR, I add the ability for settle_community_fund_participation to support the 1-proposal flow. This required a few changes:

1. A change of authorization method. Since the SNS is now created after the 1-prop is executed, the swap_canister_id is not part of the proposal data. Instead, query the SNS-W canister for all deployed SNSes and see if the caller is a swap_canister.
2. Make sure refunding of maturity is supported for all error cases. This was not implemented before.
3. Set the `sns_token_swap_lifecycle` field in the CSNS proposal_data field as it transitions through its state. This is what supports idempotency for settling of the Neurons' fund.
4. Tests on tests

Closes NNS1-2448 

Closes NNS1-2448

See merge request dfinity-lab/public/ic!13898
  • Loading branch information
DanielThurau committed Aug 1, 2023
2 parents 329d5f3 + 99d5db0 commit f8f59f8
Show file tree
Hide file tree
Showing 4 changed files with 843 additions and 88 deletions.

0 comments on commit f8f59f8

Please sign in to comment.