chore: some gardening in the codebase #4393
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ggreif
force-pushed
the
gabor/gardening
branch
from
a2a9ff8
to
a9ea1c2
Compare
ggreif
commented
Feb 12, 2024
| @@ -274,7 +274,6 @@ and objblock s ty dec_fields = | |||
| %type<Mo_def.Syntax.dec list> seplist(imp,semicolon) seplist(imp,SEMICOLON) seplist(dec,semicolon) seplist(dec,SEMICOLON) | |||
| %type<Mo_def.Syntax.exp list> seplist(exp_nonvar(ob),COMMA) seplist(exp(ob),COMMA) | |||
| %type<Mo_def.Syntax.exp_field list> seplist1(exp_field,semicolon) seplist(exp_field,semicolon) | |||
| %type<Mo_def.Syntax.exp list> separated_nonempty_list(AND, exp_post(ob)) | |||
There was a problem hiding this comment.
looks like inference gets this
ggreif
commented
Feb 12, 2024
crusso
reviewed
Feb 13, 2024
| @@ -983,18 +983,18 @@ let import_compiled_class (lib : S.comp_unit) wasm : import_declaration = | |||
| let import_prelude prelude : import_declaration = | |||
| decs prelude.it | |||
|
|
|||
| let inject_decs extra_ds u = | |||
| let inject_decs extra_ds = | |||
There was a problem hiding this comment.
That's fine, but I actually prefer the explict match because then you see the arity of the function in the header.
I wonder if this actually produces more allocation, compiling to a proper curried function rather and a fast 2-argument Ocaml function (not that it matters here, but it could eslewhere).
ggreif
force-pushed
the
gabor/gardening
branch
from
a9ea1c2
to
690a5e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some code cleanups broken out from #4371.
No functionality changes.