feat: custom RTS functions using a Wasm custom section #4424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n/ffi-custom-section
…n/ffi-custom-section
…n/ffi-custom-section
rvanasa
commented
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #4413 using a Wasm custom section in place of compiler flags. This makes it simpler to use Rust bindings without relying on external tooling to pass the expected Rust function names.
The current format of the custom section is simply a list of RTS function names separated by semicolon characters (
;), ignoring whitespace adjacent to each name, and ignoring empty strings (e.g.hello; echo;).In the future, we could extend this format to specify the expected Motoko type in a backwards-compatible way (for example,
hello; echo : <T>(T) -> T;)