exploration: finally
#4507
exploration: finally
#4507
Conversation
ggreif
added
feature
| let k' = fun v1 -> interpret_catches env cases exp.at v1 k in | ||
| let env' = { env with throws = Some k' } in | ||
| interpret_exp env' exp1 k | ||
| | TryE (exp1, cases, Some exp2) -> | ||
| let k' v1 = | ||
| let cleanup v2 = interpret_exp env exp2 (fun _ -> k v2) in |
There was a problem hiding this comment.
instead of ignoring what comes out of exp2's evaluation, explicitly check that it is unit: use V.as_unit
| let cleanup v2 = interpret_exp env exp2 (fun _ -> k v2) in | ||
| interpret_catches env cases exp.at v1 cleanup in | ||
| let env' = { env with throws = Some k' } in | ||
| let k'' v2 = interpret_exp env' exp2 (fun _ -> k v2) in |
src/mo_interpreter/interpret.ml
Outdated
| let k' v1 = | ||
| let cleanup v2 = interpret_exp env exp2 (fun _ -> k v2) in | ||
| interpret_catches env cases exp.at v1 cleanup in | ||
| let env' = { env with throws = Some k' } in |
There was a problem hiding this comment.
I'm not sure this is enough. Unless we disallow returns and breaks from exp1 and cases, I think you will need to redefine the rets and labs continuations too, to execute the finally before proceeding. This is getting complicated....
There was a problem hiding this comment.
I think your current code will allow a return (or break) from exp1 or cases to skip the finally clause - only if the execution falls through exp1 or cases is the finally clause executed. A throw from cases will probably also bypass the finally.
There was a problem hiding this comment.
Probably worth having a careful read of this https://learn.microsoft.com/en-us/dotnet/csharp/language-reference/language-specification/statements#1311-the-try-statement
(I am not entrely sure abou this...)
Let's figure out how to interpret
finallyfirst...TODO:
Throwand regular continuations inawait.ml(instead of desugaring)contextkey sortCleanup, stack up continuations of finally blocks onlykrinawait.mltokrc(CPSAwait), passCleanupcontinuations ascasync.mllowerCPSAwaitto that toocheck_ir.ml, etc.do...finally(when there is nocatchclause necessary)finallyclausetryOtherPrim "call_raw"+ testscps_asyncEsimilarly toCallPrim/3