Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use provided log utils #1784

Merged
merged 5 commits into from
May 19, 2024

Conversation

czubocha
Copy link
Contributor

@czubocha czubocha commented May 9, 2024

Description

Use log utils provided in the constructor (constructor(serverless, cliOptions, utils), docs) instead of importing @serverless/utils

Motivation and Context

@serverless/utils/log.js is going to be deprecated

How Has This Been Tested?

test:unit passed

Screenshots (if appropriate):

Manual tests:

    log.error("error", new Error("test error"))
    log.info("info", "test info")
    log.verbose("verbose", "test verbose")
    log.warning("warning", "test warning")
    const p = progress.get("test")
    p.notice("test progress")
    setTimeout(() => {
      p.remove()
    }, 5000)
image

@czubocha
Copy link
Contributor Author

czubocha commented May 13, 2024

Hey @DorianMazur, can you review this PR so we can merge it to ensure Serverless Offline works with the upcoming Serverless Framework v4 release?

@czubocha
Copy link
Contributor Author

@DorianMazur have you had a chance to take a look at this PR?

@DorianMazur
Copy link
Collaborator

@czubocha Yes, I will test it and probably merge it this weekend.

@DorianMazur DorianMazur merged commit 93fafdb into dherault:master May 19, 2024
9 checks passed
cnuss added a commit to scaffoldly/serverless-offline that referenced this pull request May 19, 2024
* master:
  refactor: use provided log utils (dherault#1784)
  fix: skip adding authorizer to event if no authorizer is configured (dherault#1786)
  Update README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants