Let podmin send private messages to local users #8246
Conversation
|
This PR should be renamed to "private message" instead of "mails", it confused me 😛 |
| @@ -20,7 +20,11 @@ def index | |||
| format.json { | |||
| @people = if params[:q].present? | |||
| mutual = params[:mutual].present? && params[:mutual] | |||
| Person.search(params[:q], current_user, only_contacts: true, mutual: mutual).limit(15) | |||
There was a problem hiding this comment.
I'm not sure that's the good place to put that changes. If the comment above is right, "Used for mentions" means an admin will be able to @username the user when writing a post. I am not sure that gives access to the post to the user, and it will have to be put in an aspect etc, that's not practical. I think private messages are what we want to achieve here.
| @@ -37,7 +36,12 @@ def create | |||
| # This will have to be removed when mobile autocomplete is ported to Typeahead | |||
| recipients_param, column = [%i(contact_ids id), %i(person_ids person_id)].find {|param, _| params[param].present? } | |||
| if recipients_param | |||
| person_ids = current_user.contacts.mutual.where(column => params[recipients_param].split(",")).pluck(:person_id) | |||
| # As an admin, I want to send a message to all local user | |||
There was a problem hiding this comment.
Okay now I get why you modified the contacts controller, it was to get the autocomplete here to work. But as an admin is able to contact anyone, I guess to add a new route which returns every local user is fine, and this shouldn't be in the contacts controller I guess. Maybe it even already exists. Can you tell us @jhass, or where to put it if it doesn't exist?
There was a problem hiding this comment.
Function differs if admin parses person_ids or a non-admin user parses person_ids. Different endpoints seems for me a bit complicated. (Check in frontend which role a user has, then change endpoints for same data with different filter) What do others think?
| @@ -118,4 +121,11 @@ def contacts_data | |||
| {value: contact_id, name: ERB::Util.h(Person.name_from_attrs(*name_attrs)) } | |||
| } | |||
| end | |||
|
|
|||
| def no_contacts? | |||
There was a problem hiding this comment.
Can you make that a bit more explicit? not_admin_and_no_contacts? for example?
There was a problem hiding this comment.
"no_contacts_for_user" / "no_contacts_for_users_role"? .. For admin seems to specialized fo me for a methods' name?
tclaus
changed the title
Hidden under this headline #7297 a podmin should be allowed to send a message to it's local users even when they don't share each others.
Together with improved report system (see PR #8239 ), there are some cases when a podmin needs to get in contact for a specific topic to its users.
There are also many other situations where a private message is very helpful between podmin and users.