Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated gem devise_lastseenable & Add devise_last_seen #8286

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

brunoocasali
Copy link

@brunoocasali brunoocasali commented Sep 1, 2021

Closes #4807

#4807

As @tclaus mentioned, the default interval time is still 5 minutes as the old implementation, but now is configurable by devise's setup initializer.

@jhass feel to free to checkout the https://github.com/brunoocasali/devise_last_seen gem ;)

@brunoocasali brunoocasali mentioned this pull request Sep 1, 2021
7 tasks
@tclaus
Copy link
Member

tclaus commented Sep 4, 2021

I just pulled this PR and it works.
You should have mention, that the default update rate is set to 5min, which is great.
So - it just works for me. The last_seen field is updated every 5 minutes on user actions.

@brunoocasali
Copy link
Author

brunoocasali commented Mar 28, 2022

Hey folks, should I review the conflicts or there is no intention to merge this at all? 😬

@tclaus
Copy link
Member

tclaus commented Mar 28, 2022

Gem deps are merged usually later and then in batches, so don't hold your breath.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polish devise_lastseenable
3 participants