Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ruby 3.1, drop ruby 2.7 #8426

Merged
merged 5 commits into from
Jun 12, 2023
Merged

Conversation

SuperTux88
Copy link
Member

So that fixes the rest of the things required to support ruby 3.1. And I also dropped 2.7 instead (it's EOL anyway, so I don't think there is a need to support it any longer?). And as we don't have 2.7 anymore, I also changed to workaround from #8425 to be simpler, as mentioned in #8424 (comment)

This is required for ruby 3.1 with rails 6.1, as they were removed from
being bundled with ruby 3.1. It can be removed with rails 7 again, as
they were added as a dependency to rails 7.
The matrix gem was removed from ruby 3.1, but was required for capybara,
but the current version added it as a dependency.
@SuperTux88 SuperTux88 added this to the 1.0.0 milestone Jun 12, 2023
Copy link
Member

@denschub denschub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Full support. I added a section to the changelog yesterday, we can just edit that to say that 2.7 is no longer supported. This might trip up some folks running develop, as up until literally yesterday, 2.7 was the only supported version, but it was overdue.

@SuperTux88 SuperTux88 merged commit b34a184 into diaspora:develop Jun 12, 2023
11 of 12 checks passed
@SuperTux88 SuperTux88 deleted the add-ruby-3.1 branch June 12, 2023 02:10
@SuperTux88
Copy link
Member Author

This might trip up some folks running develop, as up until literally yesterday, 2.7 was the only supported version, but it was overdue.

I hope people running develop are paying a bit more attention to the changelog, but some people are maybe also already waiting for newer ruby versions as 2.7 is already EOL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants