Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user limits #22479

Open
wants to merge 27 commits into
base: main
Choose a base branch
from
Open

Add user limits #22479

wants to merge 27 commits into from
+1,150 −21

Conversation

licitdev
Copy link
Member

@licitdev licitdev commented May 13, 2024 •
edited

Scope

What's changed:

  • Added user limits for Admin, App and API accesses
  • Limit can be used to restrict public registration

Potential Risks / Drawbacks

  • Needs further testing for edge cases

Review Notes / Questions

  • Todo Unit Tests

Implements the limits mentioned in issue #21981 for Public Registration #22125

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 13, 2024 •
edited

🦋 Changeset detected

Latest commit: 79fadfc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@directus/api Minor
@directus/env Patch
@directus/errors Patch
directus Patch
@directus/extensions-registry Patch
@directus/memory Patch
@directus/validation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@DanielBiegler DanielBiegler self-requested a review May 24, 2024 09:42
@br41nslug br41nslug added this to the Next Minor Release milestone May 24, 2024
@alexchopin alexchopin requested a review from br41nslug May 24, 2024 12:34
@licitdev licitdev marked this pull request as ready for review May 27, 2024 14:52
br41nslug
br41nslug reviewed May 28, 2024
View reviewed changes
api/src/services/roles.test.ts Outdated Show resolved Hide resolved
packages/env/src/constants/directus-variables.ts Outdated Show resolved Hide resolved
packages/env/src/constants/directus-variables.ts Outdated Show resolved Hide resolved
api/src/telemetry/utils/get-role-counts-by-roles.ts Outdated Show resolved Hide resolved
api/src/services/users.ts Show resolved Hide resolved
api/src/telemetry/utils/check-increased-user-limits.ts Outdated Show resolved Hide resolved
api/src/telemetry/utils/get-role-counts-by-users.ts Outdated Show resolved Hide resolved
@br41nslug br41nslug requested a review from paescuj May 30, 2024 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paescuj paescuj paescuj left review comments

@br41nslug br41nslug br41nslug approved these changes

@DanielBiegler DanielBiegler Awaiting requested review from DanielBiegler

Assignees

@br41nslug br41nslug

Labels
🍰 Improvement
Projects
Software Roadmap
Status: 👀 In review
Milestone
Next Minor Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@licitdev @paescuj @br41nslug