Fix item fetching in calendar layout when switching view #22517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ccbdb61 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
When switching the view in the calendar layout (e.g. from month to week, navigating between months, ...), the items are currently not re-fetched and thus not displayed. This is fixed now, by ensuring the applied calendar filter is based on the latest view data.
before.mp4
after.mp4
Potential Risks / Drawbacks
None
Review Notes / Questions
calendar.value.viewis not reactive, therefore subscribing toviewInfowhich is updated whenever the view changes. Values are still taken fromcalendar.value.viewsince it also contains the initial values (viewInfodoes not).Related to #21539