Fixed #35443 -- Changed ordinal to return negative integers as is. #18172
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello! Thank you for your contribution 💪
As it's your first contribution be sure to check out the patch review checklist.
If you're fixing a ticket from Trac make sure to set the "Has patch" flag and include a link to this PR in the ticket!
If you have any design or process questions then you can ask in the Django forum.
Welcome aboard ⛵️!
|
You beat me to it. I like the test with |
Thanks :) I committed a fixup (8130b21) for the docs. Unsure what the policy for this is, but I assume everything is squashed when accepted? Didn't want to alter the history with a force push. |
There was a problem hiding this comment.
Thank you for your contribution! I’ve reviewed the code, tests, and documentation, and they all appear to follow the guidelines. However, for the pull request itself, the commits need to be squashed into a single commit. Once that’s done, it can proceed with the review.
Great! The commits are now squashed. Thanks for the help. |
Previously, `-1` was converted to `"-1th"`. This has been updated to return negative numbers "as is", so that for example `-1` is converted to `"-1"`. This is now explicit in the docs. Co-authored-by: Martin Jonson <artin.onson@gmail.com>
Trac ticket number
ticket-35443
Branch description
"-1st", "-2nd" and so on are incorrect words. Function
ordinalin modulehumanizehas been changed to return negative number "as is", so that for example-1is converted to"-1".The changes corresponds to alternative 1 of the suggested solutions in ticket #35443, which was accepted by Sarah Boyce.
Checklist
mainbranch.