Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

Azure plugins - instance and loadbalancer #709

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

chungers
Copy link
Contributor

@chungers chungers commented Oct 1, 2017

This PR adds support for creating VM instances on Azure.

  • Added package in pkg/provider/azure
  • Added driver in pkg/run/v0/azure to associate with a new kind azure (for infrakit plugin start).
  • Load the package in cmd/infrakit main.

TODO:

  • Tests
  • Support for basic resource types such as Disks and Subnets.

Signed-off-by: David Chung david.chung@docker.com

David Chung added 3 commits October 1, 2017 12:07
Signed-off-by: David Chung <david.chung@docker.com>
Signed-off-by: David Chung <david.chung@docker.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "azure-plugin" git@github.com:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354187600
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov
Copy link

codecov bot commented Oct 2, 2017

Codecov Report

Merging #709 into master will increase coverage by 16.46%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #709       +/-   ##
===========================================
+ Coverage   46.66%   63.12%   +16.46%     
===========================================
  Files          85        7       -78     
  Lines        9404      659     -8745     
===========================================
- Hits         4388      416     -3972     
+ Misses       4683      192     -4491     
+ Partials      333       51      -282
Impacted Files Coverage Δ
pkg/template/defaults.go
pkg/provider/google/plugin/instance/util/name.go
pkg/provider/rackhd/plugin/instance/builder.go
pkg/types/error.go
pkg/provider/aws/plugin/instance/ec2_volume.go
pkg/types/path.go
pkg/types/reflect.go
pkg/types/object.go
pkg/provider/aws/plugin/instance/dynamodb_table.go
...der/aws/plugin/instance/cloudwatchlogs_loggroup.go
... and 68 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49f1bae...2445e22. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants