Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engdocs 2080 #19953

Merged
merged 7 commits into from
May 20, 2024
Merged

Engdocs 2080 #19953

merged 7 commits into from
May 20, 2024

Conversation

aevesdocker
Copy link
Contributor

@aevesdocker aevesdocker commented May 2, 2024

Description

PR creates includes for the Compose GUI feature. No new content, just rejigging.

Related issues or tickets

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/compose Relates to docker-compose.yml spec or docker-compose binary label May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 9a5d78d
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/664772c404e6e4000868e580
😎 Deploy Preview https://deploy-preview-19953--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aevesdocker aevesdocker marked this pull request as ready for review May 17, 2024 09:15
@@ -0,0 +1,3 @@
The `healthcheck` attribute declares a check that's run to determine whether or not the service containers are "healthy". It works in the same way, and has the same default values, as the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code formatting and links don't format correctly in includes. Will address this in a follow up PR

@aevesdocker aevesdocker requested a review from a team May 17, 2024 09:17
@dvdksn
Copy link
Contributor

dvdksn commented May 17, 2024

How is Docker Desktop pulling these descriptions? If it's happening runtime, I think we need an intermediate layer, such as a JSON API like we have for the search index, which decouples the source files and the distribution of headless fragments.

content/includes/compose/include.md Outdated Show resolved Hide resolved
content/compose/compose-file/build.md Outdated Show resolved Hide resolved
content/includes/compose/develop.md Outdated Show resolved Hide resolved
content/compose/compose-file/develop.md Show resolved Hide resolved
content/compose/compose-file/develop.md Show resolved Hide resolved
content/compose/compose-file/06-networks.md Show resolved Hide resolved
content/includes/compose/profiles.md Outdated Show resolved Hide resolved
content/includes/compose/services-networks.md Outdated Show resolved Hide resolved
content/includes/compose/services-ports.md Outdated Show resolved Hide resolved
content/compose/compose-file/05-services.md Show resolved Hide resolved
@dvdksn
Copy link
Contributor

dvdksn commented May 17, 2024

How is Docker Desktop pulling these descriptions? If it's happening runtime, I think we need an intermediate layer, such as a JSON API like we have for the search index, which decouples the source files and the distribution of headless fragments.

I discussed this with @jhrotko and I think we need to provide a more reliable endpoint that Docker Desktop can use to fetch these strings. For the same reason that we use /go/ links, to avoid unintentionally breaking an application. Fetching these strings from the markdown files is too brittle.

I can do the implementation. I think we should serve these as a JSON file. We may need to serve other applications in a similar way in the future, so if we want to be future-proof we should make this a generic implementation. The most straightforward and generic approach is to just assign each string a unique identifier:

{
  "composeBuild": "Build is an optional part of the Compose Specification. It tells Compose how to (re)build an application from source and lets you define the build process within a Compose file in a portable way.",
  "composeVolumes": "Volumes are persistent data stores implemented by the container engine. Compose offers a neutral way for services to mount volumes, and configuration parameters to allocate them to infrastructure. The top-level `volumes` declaration lets you configure named volumes that can be reused across multiple services."
}

We should probably stick a /go/ redirect in front of this too.

@aevesdocker
Copy link
Contributor Author

@dvdksn sounds good. I just pushed Joana's review comments and added some more files, so I guess now over to you? Is it easier to get this merged first?

Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge @aevesdocker and I can open a follow-up

Copy link
Contributor

@jhrotko jhrotko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aevesdocker aevesdocker merged commit 7598097 into docker:main May 20, 2024
10 checks passed
@dvdksn dvdksn mentioned this pull request May 20, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compose Relates to docker-compose.yml spec or docker-compose binary status/review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants