-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Engdocs 2080 #19953
Engdocs 2080 #19953
Conversation
✅ Deploy Preview for docsdocker ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@@ -0,0 +1,3 @@ | |||
The `healthcheck` attribute declares a check that's run to determine whether or not the service containers are "healthy". It works in the same way, and has the same default values, as the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code formatting and links don't format correctly in includes. Will address this in a follow up PR
How is Docker Desktop pulling these descriptions? If it's happening runtime, I think we need an intermediate layer, such as a JSON API like we have for the search index, which decouples the source files and the distribution of headless fragments. |
I discussed this with @jhrotko and I think we need to provide a more reliable endpoint that Docker Desktop can use to fetch these strings. For the same reason that we use I can do the implementation. I think we should serve these as a JSON file. We may need to serve other applications in a similar way in the future, so if we want to be future-proof we should make this a generic implementation. The most straightforward and generic approach is to just assign each string a unique identifier: {
"composeBuild": "Build is an optional part of the Compose Specification. It tells Compose how to (re)build an application from source and lets you define the build process within a Compose file in a portable way.",
"composeVolumes": "Volumes are persistent data stores implemented by the container engine. Compose offers a neutral way for services to mount volumes, and configuration parameters to allocate them to infrastructure. The top-level `volumes` declaration lets you configure named volumes that can be reused across multiple services."
} We should probably stick a |
@dvdksn sounds good. I just pushed Joana's review comments and added some more files, so I guess now over to you? Is it easier to get this merged first? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel free to merge @aevesdocker and I can open a follow-up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
PR creates includes for the Compose GUI feature. No new content, just rejigging.
Related issues or tickets
Reviews