Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update provisioning pages and add group mapping steps #20016

Merged
merged 9 commits into from
May 21, 2024
Merged

Update provisioning pages and add group mapping steps #20016

merged 9 commits into from
May 21, 2024

Conversation

stephaurelio
Copy link
Contributor

@stephaurelio stephaurelio commented May 10, 2024 •
edited

Description

This PR:

  • Adds IdP-specific group mapping steps
  • Pulls JIT content out of group mapping page into its own page
  • Updates the ToC to group provisioning pages together.

Deploy previews:

Related issues or tickets

Closes JIRA: https://docker.atlassian.net/browse/ENGDOCS-2017

Reviews

@github-actions github-actions bot added area/hub Issue affects Docker Hub area/security area/subscription Relates to Docker pricing and subscription area/api Relates to Docker API docs area/admin Relates to Docker Admin hugo Updates related to hugo labels May 10, 2024
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit d4cc4e6
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/6647e29536cdfd0008558c97
😎 Deploy Preview https://deploy-preview-20016--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stephaurelio stephaurelio mentioned this pull request May 10, 2024
Closed
3 tasks
@github-actions github-actions bot added the area/release Relates to CI or deployment label May 10, 2024
@stephaurelio stephaurelio marked this pull request as ready for review May 10, 2024 16:51
@stephaurelio stephaurelio requested review from ivan-californias and ajthilakan and removed request for aevesdocker and craig-osterhout May 10, 2024 16:51
@stephaurelio stephaurelio removed area/hub Issue affects Docker Hub area/subscription Relates to Docker pricing and subscription area/api Relates to Docker API docs area/release Relates to CI or deployment labels May 10, 2024
@github-actions github-actions bot added area/hub Issue affects Docker Hub area/subscription Relates to Docker pricing and subscription area/api Relates to Docker API docs area/release Relates to CI or deployment labels May 14, 2024
@stephaurelio stephaurelio requested a review from a team May 16, 2024 18:56
@stephaurelio stephaurelio added status/review and removed area/subscription Relates to Docker pricing and subscription area/api Relates to Docker API docs area/release Relates to CI or deployment labels May 16, 2024
@github-actions github-actions bot added area/subscription Relates to Docker pricing and subscription area/api Relates to Docker API docs area/release Relates to CI or deployment labels May 17, 2024
dvdksn
dvdksn reviewed May 17, 2024
View reviewed changes
Copy link
Contributor

@dvdksn dvdksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads so well, you're an incredible writer. All I got is nits.

content/security/for-admins/provisioning/group-mapping.md Outdated Show resolved Hide resolved
content/security/for-admins/provisioning/group-mapping.md Outdated Show resolved Hide resolved
content/security/for-admins/provisioning/group-mapping.md Outdated Show resolved Hide resolved
content/security/for-admins/provisioning/group-mapping.md Outdated Show resolved Hide resolved
ivan-californias
ivan-californias approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@ivan-californias ivan-californias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@stephaurelio stephaurelio requested a review from dvdksn May 17, 2024 23:07
@stephaurelio stephaurelio merged commit 0e1aaa6 into docker:main May 21, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivan-californias ivan-californias ivan-californias approved these changes

@dvdksn dvdksn dvdksn approved these changes

@ajthilakan ajthilakan Awaiting requested review from ajthilakan

Assignees
No one assigned
Labels
area/admin Relates to Docker Admin area/api Relates to Docker API docs area/hub Issue affects Docker Hub area/release Relates to CI or deployment area/security area/subscription Relates to Docker pricing and subscription hugo Updates related to hugo status/review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stephaurelio @ivan-californias @dvdksn