Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Update instructions in language-specific guides. #20060

Merged
merged 2 commits into from
May 19, 2024
Merged

docs: Update instructions in language-specific guides. #20060

merged 2 commits into from
May 19, 2024

Conversation

Pradumnasaraf
Copy link
Contributor

@Pradumnasaraf Pradumnasaraf commented May 19, 2024 •
edited

Description

Update the remaining languages CI configurations section as follows:

  • Specify the type of secret required to be created, as GitHub now has two kinds of secrets under Secrets and variables - Environment and Repository secret.
  • Improve the context of a couple of sentences.

Reviews

  • Technical review
  • Editorial review
  • Product review

@github-actions github-actions bot added the area/get-started Relates to get started and onboarding docs label May 19, 2024
@netlify Netlify
Copy link

netlify bot commented May 19, 2024 •
edited

✅ Deploy Preview for docsdocker ready!

Name Link
🔨 Latest commit 126709e
🔍 Latest deploy log https://app.netlify.com/sites/docsdocker/deploys/664982ab918b2000082a3781
😎 Deploy Preview https://deploy-preview-20060--docsdocker.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

craig-osterhout
craig-osterhout approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@craig-osterhout craig-osterhout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM

@craig-osterhout craig-osterhout merged commit 74bad3d into docker:main May 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@craig-osterhout craig-osterhout craig-osterhout approved these changes

Assignees
No one assigned
Labels
area/get-started Relates to get started and onboarding docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pradumnasaraf @craig-osterhout