Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable write-ahead logging and memory mapped IO #5005

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

samuel-w
Copy link
Contributor

Prior pull request #4612, I broke it with a force push.

I set locking_mode to exclusive for highest compatibility with WAL, and got the mmap number from the SQLite documentation.

Also set locking mode to exclusive for highest compatibility (and possible performance increase)
@gpatel-fr
Copy link
Contributor

Hello

thanks for the PR, however I don't see why it's necessary. With #4907 any Sqlite option can be set.
In my case I set it like that:

CUSTOMSQLITEOPTIONS_DUPLICATI=cache_size=-300000;temp_store=2;journal_mode=WAL;synchronous=Normal

but you can use any option you want.

This has IMO 2 advantages over your PR:

  • first it does not impose any particular option to the user who has the possibility to set whatever is felt better so it's better for experts
  • Second, enabling the WAL in all cases change the way of copying the database, something that can and do confuse ordinary users so it's better for beginners who could copy databases without much caring if they are opened or not, and what is less confusing for beginners lead to less anguished posts on the forum.

I agree that using WAL is better for insert performance, however Duplicati performance depends on many parameters and enabling WAL can lead to no significant enhancement if other effects are dominant, see my post here:

https://forum.duplicati.com/t/backup-upload-speed/16684/1

@gpatel-fr gpatel-fr added the pending user feedback needs information from the original poster label Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending user feedback needs information from the original poster
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants