Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make the delay for retry-after static #5011

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gpatel-fr
Copy link
Contributor

so it's kept when the backend is recreated - it happens every time the retry-after is set.
Also, as having the cloud throttling the connection is a serious event, make it a warning instead of a profiling event so it will not be hidden from the user.

recreated - this happens every time the retry-after is set.
as having the cloud throttling the connection is a serious event,
make it a warning instead of a profiling event so it will not be hidden.
@duplicatibot
Copy link

This pull request has been mentioned on Duplicati. There might be relevant details there:

https://forum.duplicati.com/t/duplicati-stuck-on-compact-when-getting-putting-from-onedrive-and-results-in-missing-files/16641/53

@Jojo-1000
Copy link
Contributor

I think it might be better to make the retry after variable for each backend that uses it static. That way the different backend APIs are not mixed, although it probably doesn't matter much.

@gpatel-fr
Copy link
Contributor Author

I don't parse the meaning for 'each backend that uses it'. There is only one backend that uses it: OneDrive. Maybe it was intended to be shared with other drivers but so far it has not happened. That's why I have modified it as if it was under the OneDrive directory, because for all intends and purposes it's the case.

@tygill
Copy link
Contributor

tygill commented Sep 6, 2023

A simple way to make it static per backend would be to have the helper take a ref parameter to track the state in. Each backend that wants to use it could then have its own static that it passes in each time it is called.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants