change query for GetBlocklists in LocalDatabase.cs #5066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to avoid duplicates caused by versions using the same block(s) credits (https://forum.duplicati.com/t/any-way-to-recover-backup-repair-and-purge-broken-files-dont-help/17048): ts678 for the use case, @Jojo-1000 for the fix
Jojo-1000
reviewed
Dec 12, 2023
| blocksize / hashsize | ||
| // DISTINCT is used to remove duplicates that can happen when several backup versions uses the same block | ||
| var sql = string.Format( | ||
| @"SELECT DISTINCT A.Hash AS BlocklistHash, C.Hash AS BlockHash, B.""Index"" " + |
There was a problem hiding this comment.
Unfortunately, I don't think a select distinct is going to work here. The "Index" is not guaranteed to always be the same:
Example: fill file with 32769 "a" characters (one full blocklist + "a"), then change to 65536 "b" (two full blocklists) + "a" at the end (total 65537), the second "a" blocklist will have index 2 and your query will fail (I tested this just now). This is why I resorted to GROUP BY in my fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to avoid duplicates caused by versions using the same block(s)
credits (https://forum.duplicati.com/t/any-way-to-recover-backup-repair-and-purge-broken-files-dont-help/17048): ts678 for the use case, @Jojo-1000 for the fix